Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide disabled fields in show page #1051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hide disabled fields in show page #1051

wants to merge 1 commit into from

Conversation

mikesndrs
Copy link
Contributor

@mikesndrs mikesndrs commented Nov 20, 2024 •
edited
Loading

Summary of changes
Hide disabled fields on show page in addition to form page, also add some fields to be disabled for events

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

fbacall
fbacall requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@fbacall fbacall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that ensures a disable attribute is not displayed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbacall fbacall fbacall requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesndrs @fbacall